Remove unused ValidDiscordServerInvite converter#3307
Merged
ChrisLovering merged 1 commit intopython-discord:mainfrom Apr 6, 2025
Merged
Conversation
ChrisLovering
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converter is not used anywhere.
In addition, this converter is vulnerable to Server-Side Request Forgery. If the argument looks like
discord.gg/../nefarious, this converter is going to make the requestGET https://discordapp.com/api/v7/invites/../nefarious, which is the same asGET https://discordapp.com/api/v7/nefarious.Example of how it could be exploited:
discord.gg/../guilds/267624335836053506/bans/12345(Get Guild Ban)So let's delete this so that we don't accidentally use it