Fix Windows launcher shebang bounds - #5291
Open
stanbot8 wants to merge 1 commit into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows launcher parser could write one byte past its fixed shebang buffer and form a pointer before that buffer. A maximal launcher shebang without a newline could corrupt adjacent process memory while parsing a generated executable.
Keep Windows launcher shebang reads and parser pointers within the fixed buffer.
I did not include the 8 launcher binaries because they are not reviewable from the diff. A maintainer must regenerate them in the project's trusted Windows build environment by running python
tools/build_launchers.py.newsfragments/. (See documentation for details)