Skip to content

Remove autocommand from vendored dependencies - #5289

Open
Kielek wants to merge 2 commits into
pypa:mainfrom
Kielek:bump-vendored-code
Open

Remove autocommand from vendored dependencies#5289
Kielek wants to merge 2 commits into
pypa:mainfrom
Kielek:bump-vendored-code

Conversation

@Kielek

@Kielek Kielek commented Aug 5, 2026

Copy link
Copy Markdown

Summary of changes

Raise the minimum jaraco.text version to 4.3.0 and regenerate the complete vendored dependency closure.

Updated:

  • jaraco.text 4.0.0 -> 4.3.0
  • jaraco.context 6.1.0 -> 6.1.2
  • jaraco.functools 4.4.0 -> 4.6.0
  • more-itertools 10.8.0 -> 11.1.0
  • packaging 26.0 -> 26.3
  • tomli 2.4.0 -> 2.4.1
  • wheel 0.46.3 -> 0.47.0

Added:

  • annotated-doc 0.0.5
  • colorama 0.4.6
  • markdown-it-py 4.2.0
  • mdurl 0.1.2
  • Pygments 2.20.0
  • rich 15.0.0
  • shellingham 1.5.4
  • typer 0.27.1
  • typer-slim 0.24.0

Dropped:

  • autocommand 2.2.2
  • importlib_metadata 8.7.1
  • platformdirs 4.4.0
  • zipp 3.23.0

backports.tarfile remains at 1.2.0 and was refreshed with the rest of the vendored tree.

Assisted-by: Codex

Closes #5049

Pull Request Checklist

@Kielek
Kielek force-pushed the bump-vendored-code branch from b0083d9 to f4239aa Compare August 5, 2026 14:12
@Kielek

Kielek commented Aug 5, 2026

Copy link
Copy Markdown
Author

In https://github.com/open-telemetry/opentelemetry-demo/ we have setuptools as indirect dependency. It brings also autocommand which is problematic. It will be great to fully remove it from the chain. It is the easiest way, the hard part is to document usage and ask CNCF team for the exception for usage.

Please let me know what do you think about these changes. I know that the PR contain a lot of changes, but I do not see possibility to make the changes small.

Raise the minimum jaraco.text version to 4.3.0 and regenerate the
complete vendored dependency closure.

Updated:
- jaraco.text 4.0.0 -> 4.3.0
- jaraco.context 6.1.0 -> 6.1.2
- jaraco.functools 4.4.0 -> 4.6.0
- more-itertools 10.8.0 -> 11.1.0
- packaging 26.0 -> 26.3
- tomli 2.4.0 -> 2.4.1
- wheel 0.46.3 -> 0.47.0

Added:
- annotated-doc 0.0.5
- colorama 0.4.6
- markdown-it-py 4.2.0
- mdurl 0.1.2
- Pygments 2.20.0
- rich 15.0.0
- shellingham 1.5.4
- typer 0.27.1
- typer-slim 0.24.0

Dropped:
- autocommand 2.2.2
- importlib_metadata 8.7.1
- platformdirs 4.4.0
- zipp 3.23.0

backports.tarfile remains at 1.2.0 and was refreshed with the rest of
the vendored tree.

Prune dependency test suites and stale launcher entries from the
vendored tree so wheels remain test-free and repeated vendoring is
stable across platforms.

Assisted-by: Codex
@Kielek
Kielek force-pushed the bump-vendored-code branch from f4239aa to 71e9b29 Compare August 5, 2026 14:37
@Kielek
Kielek marked this pull request as ready for review August 5, 2026 14:37
Copilot AI lite review requested due to automatic review settings August 5, 2026 14:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@ngoldbaum

Copy link
Copy Markdown
Contributor

A 200k LoC diff seems pretty large! Did you see #5256 where I tried to do this? Do you understand where the huge diff is coming from?

@Kielek

Kielek commented Aug 13, 2026

Copy link
Copy Markdown
Author

@ngoldbaum, I have seen your PR. It is not solving licensing-chain problem. It still references autocommand.

If we speaking about 200k Loc changes. I agree that it is huge, but it should be managable by the maintainers. If I would to accept this kind of changes, I would repeat exercise from scratch. If there will be no differences, I would accept such PR. The only additional condition is if you are fine with the new dependency chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setuptools contains code under LGPLv3, BSD, Apache, and PSFL

3 participants