perf(specifiers): cache a Specifier's canonical form - #1372
Open
notatallshaw wants to merge 1 commit into
Open
Conversation
notatallshaw
marked this pull request as draft
August 8, 2026 19:14
Member
Author
|
Faster: |
notatallshaw
marked this pull request as ready for review
August 8, 2026 19:33
Contributor
|
A few things from a Fable review, if you want: (1: A helper might have a cost, probably not worth it) 🤖 AI text below 🤖 The review found no correctness bugs in the caching change itself — verifiers independently confirmed the cache invalidation on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifier.__hash__and__eq__both read_canonical_spec, which recomputedcanonicalize_versionon every call. This memoizes it in a slot beside the existing_spec_versionand_rangescaches, cleared by__setstate__, the only path that replaces_spec.Warm, on CPython 3.12 and 3.14:
SpecifierhashSpecifierequalitySpecifierSetconstruct + dedup