Skip to content

Fix for issue #10969 - Pylint skipping similarly named project direct… #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cinnion wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for issue #10969 - Pylint skipping similarly named project direct… #10970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/whatsnew/fragments/10969.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Fix an issue where discovery can miss a similarly named directory if a shorter named directory is processed first.

If you have directories named say `applications` and `applications_api` in a
project, and the former is encountered by the tree walk first during discovery,
the second directory would be skipped even if it was a valid package. This fixes
the issue by appending the OS filepath separator to the name in the case where
the path was known to be a directory due to having an `__init__.py` in it.
2 changes: 1 addition & 1 deletion pylint/lint/pylinter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ def _discover_files(self, files_or_modules: Sequence[str]) -> Iterator[str]:
continue

if "__init__.py" in files:
skip_subtrees.append(root)
skip_subtrees.append(root + os.sep)
yield root
else:
yield from (
Expand Down
Loading