Extra arg for "method" (self) and "classmethod" (cls) (continued)#10885
Extra arg for "method" (self) and "classmethod" (cls) (continued)#10885jacobtylerwalls merged 12 commits intopylint-dev:mainfrom
Conversation
b2c12e8 to
74e4bb0
Compare
|
Thanks @RomanValov for finishing the work! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10885 +/- ##
==========================================
+ Coverage 96.06% 96.17% +0.10%
==========================================
Files 177 178 +1
Lines 19616 19633 +17
==========================================
+ Hits 18845 18882 +37
+ Misses 771 751 -20
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
DanielNoord
left a comment
There was a problem hiding this comment.
LGTM!
@jacobtylerwalls You also want to do a review of this?
|
@Pierre-Sassoulas isn't this only a false positive fix? Shouldn't we backport? |
|
Based on #10443 (comment) we shouldn't backport though. |
|
I have also reworked error message counters a bit, so they match in behavior now. For the function: def func(a,b,c,d,e,f,_g):
...Was: Now: |
Looking again, I don't think I realized that a change in the text of a message made it appear under "New messages". This was not helped by the fact that home-assistant was first, and exceeded 65535 characters so that we couldn't even see the "No longer emitted" section. |
Trying to fix that in #10914 |
This comment has been minimized.
This comment has been minimized.
|
OK to backport after all, then? |
(cherry picked from commit 8faa924)
…-arguments message (#10885) (#10934) (cherry picked from commit 8faa924) Co-authored-by: Roman Valov <[email protected]>
Type of Changes
Description
(non static) method and classmethod max_arg has to be incremented over the function and staticmethod one, to leave self and cls alone.
Continues #10443 by @fgallaire
Closes #8675