Fix idxminmax for interval coordinates#11313
Open
lavaFreak wants to merge 2 commits intopydata:mainfrom
Open
Conversation
dcherian
reviewed
Apr 29, 2026
| # ExtensionArray scalar wrapper. | ||
| pass | ||
| else: | ||
| coord = coord.copy(data=to_like_array(array[dim].data, array.data)) |
Contributor
There was a problem hiding this comment.
i suspect the real solution is to fix to_like_array to handle extension arrays?
Author
There was a problem hiding this comment.
Good call. I moved the fix into to_like_array() in d0f22b94 instead of keeping the one-off special case in _calc_idxminmax().
For NumPy-backed lookups, to_like_array() now converts allowed pandas extension arrays to a NumPy object array, which fixes the scalar interval selection path while keeping the idxmin/idxmax regression green.
Validation I reran locally:
.venv/bin/python -m pytest -o addopts= xarray/tests/test_dataarray.py -k 'test_idxminmax_interval_coords or test_idxmax or test_idxmin'.venv/bin/python -m ruff check xarray/computation/computation.py xarray/compat/array_api_compat.py xarray/tests/test_dataarray.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
DataArray.idxmax()andDataArray.idxmin()when the reduced dimension uses interval coordinates._calc_idxminmax()was replacing the coordinate's original pandas index adapter with a raw extension array before the final label lookup, which causes scalar interval selections to fail withTypeError: len() of unsized object.This keeps pandas extension-backed coordinates on their original adapter for the final lookup, adds a regression test for both
idxmaxandidxmin, and documents the bug fix indoc/whats-new.rst.Checklist
.idxmax()fails if coordinates are intervals #11300whats-new.rstapi.rstAI Disclosure
Tools: Codex