Fix ruff warnings#17
Open
dfandrich wants to merge 6 commits intopvi-github:mainfrom
Open
Conversation
Some variables appear to be in preparation for future use, so these are marked with a TODO comment instead.
These strings have no placeholders so f is unnecessary and slower.
This is a cleaner approach then import and catching an exception.
This makes the code easier to understand.
Owner
|
Hello... after 0.3 refactoring this PR will need to be updated. there are conflicts and IINM test are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consists of improvements like removing unused imports and variables. The
remaining warnings all appear to point to potentially legitimate errors in the
code and should be investigated. In particular, TODO comments have been added
to variables that are set but unreferenced but where it appears that they
actually ought to be used.