parser options should be a part of collected metadata#1529
Open
parser options should be a part of collected metadata#1529
Conversation
…all constructor signatures and depollute the class instantiations
Janther
force-pushed
the
trimming-options
branch
from
888d9b7 to
2f4f328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we can standardise all constructor signatures and depollute the class instantiations.
The changes are very repetitive:
typeimports andoptionsfrom constructors acrossslang-nodes.optionswithcollected.optionswhenever we actually need to access this info (only 7 times) In the constructors only.createNonterminalVariantCreatorfunction and types associated to reflect the constructor calls.slangSolidityParserinitial creation ofSourceUnitto reflect the change.CollectedMetadatainterface.