computing lastPrintableIndex only once instead of checking in every loop#1486
Merged
computing lastPrintableIndex only once instead of checking in every loop#1486
lastPrintableIndex only once instead of checking in every loop#1486Conversation
Janther
force-pushed
the
removing-nested-loop
branch
2 times, most recently
from
cec64d8 to
0aa3bfe
Compare
fvictorio
approved these changes
Apr 4, 2026
Janther
force-pushed
the
removing-nested-loop
branch
from
ddaa983 to
6060ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the only big detail here is that
findLastIndexwas introduced ines2023. So in order to take full advantage of this I updated thetargetfor thecompilerOptions.There was only one problem triggered by our current tests which was an unsafe access to an undefined value.