Conversation
Janther
added
refactor
Janther
force-pushed
the
reviewing-unneeded-typecheck
branch
from
0635a93 to
6506b49
Compare
fvictorio
approved these changes
Mar 8, 2026
Janther
force-pushed
the
reviewing-unneeded-typecheck
branch
from
6506b49 to
9d2143b
Compare
…ple also unneeded type castings
Janther
force-pushed
the
reviewing-unneeded-typecheck
branch
from
9d2143b to
2b35720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding
TerminalNodetoStrictAstNodedefinition, with this, we can get rid ofnode instanceof TerminalNode.on this same PR we also reviewed every type casting
as StrictAstNodeand cleaned the types so it wouldn't be necessary anymore. The only downside is that we needed to add a non null assertion sincepath.parentandpath.getNode()can returnundefinedif we are at the root of the tree which will not happen in our cases and to be honest, the use ofas StrictAstNodewas already masking the use of the!.