Conversation
1fbd4bd to
95d8162
Compare
95d8162 to
b3ea5e4
Compare
fvictorio
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially this PR had included a small check and early exit when the rest of the execution wouldn't alter anything, but after some profiling, I realised that this was more taxing than just keep the execution untouched.
This inspired me to change the approach of storing leading and trailing offsets.
The important information we need to check is
start - leadingOffsetandend + trailingOffset. if we store this info into the appropriately named attributesouterStartandouterEnd, then we don't need to recalculate it at each call ofupdateMetadata. Also, we don't need to reassignleadingOffsetandtrailingOffsetsince the outer bounds are static.This approach was profiled and there is a small improvement in the performance. I also appreciate the improvement in the simplicity of the code.