removing ArgumentsDeclaration from the AST tree#1270
Merged
Conversation
fvictorio
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing the idea of
extractVariantIn previous PRs we introduced the idea of
printVariantin order to avoid extra processing on Prettier's side. This is the next step of that idea where we extract thevariantat the initiation moment and ignore thePolymorphicNode. This adds the following benefits:PolymorphicNodePolymorphicNodeis now removedThe downside is that the use of
variants is used all around the codebase so the full change has been separated in individual commits (all of them will pass the CI) with a final cleanup commit.All of these commits will follow the same idea but some impact the code much deeper than others so I'll be making PRs slowly so the changes can be individually reviewed.
This PR
We skip
ArgumentsDeclaration, remove allvariantqueries, and remove all calls toprintVariantfor this particular node.