adding printVariant function to skip printing the variant node when possible#1251
Merged
adding printVariant function to skip printing the variant node when possible#1251
printVariant function to skip printing the variant node when possible#1251Conversation
fvictorio
approved these changes
Sep 13, 2025
Janther
force-pushed
the
print-variant-helper
branch
from
0eec671 to
cd4932f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prettier's
printfunction on variants executes extra steps preparing the plugin'sprintfunction print comments and checking the position of the cursor in regards to the current node.since we don't to repeat these steps another time when printing a polymorphic node which only delegates the printing to the variant, we simply avoid printing unless there's a comment attached to the polymorphic node.