better handling of empty array from inferLanguage#1175
Conversation
…s of nightly builds of `solc`
…atest supported version
inferLanguage
|
I'm not sure I prefer the new behavior. I'd personally prefer to always throw an error:
The very first improvement I would do here is to try to tell apart between those two scenarios, so that users can know what's going on. I know that's not trivial though. Then if people complain that this is too restrictive, we can consider fallback versions like you are doing here. I don't feel super strongly about this though. If you do, and think this is the best approach, then feel free to merge. |
|
the issue I'm trying to fix here is when there is a new solidity version and |
There are 2 cases in which we receive an empty array from
inferLanguage.with this in mind we are defaulting to the latest supported version and return a more detailed error.
also in this PR:
I could not parse any nightly builds even when using specific versions of nightly builds of
solc. Therefore I'm removing this test.NomicFoundation/slang#1346