Merged
Conversation
Janther
force-pushed
the
antlr-slang-tests
branch
from
4266e81 to
5373cbf
Compare
fvictorio
approved these changes
Mar 24, 2025
Member
fvictorio
left a comment
fvictorio
left a comment
There was a problem hiding this comment.
Minor comment, but feel free to ignore it and merge if you disagree.
| }), | ||
| ); | ||
|
|
||
| const unstableAntlrTests = new Map( |
Member
There was a problem hiding this comment.
Very minor, but "unstable" in the context of prettier means something else, which is how we use it below: it means that formatting it twice doesn't produce the same result as formatting it once. This name seems to say that some tests are unstable when using the ANTLR parser, but I think these are instead tests that result in a different output when using ANTLR vs Slang.
Maybe we can use something like divergentTests or antlrMismatchTests, or something like that.
Janther
force-pushed
the
antlr-slang-tests
branch
from
5373cbf to
b2274df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comparing slang and antler formats when testing so we are aware when there is a breaking change.