small refactor

Author: Janther

src/slang-nodes/ConditionalExpression.ts

@@ -50,9 +50,10 @@ function experimentalTernaries(
     path.call(print, 'trueExpression')
   ]);
 
+  const groupId = Symbol('Slang.ConditionalExpression.trueExpression');
   const conditionAndTrueExpressionGroup = group(
     [operandDoc, trueExpressionDoc],
-    { id: Symbol('Slang.ConditionalExpression.trueExpression') }
+    { id: groupId }
   );
 
   const falseExpression = path.call(print, 'falseExpression');
@@ -64,10 +65,9 @@ function experimentalTernaries(
       : ifBreak(
           [fillTab(options), indent(falseExpression)],
           [' ', falseExpression],
-          {
-            // We only add `fillTab` if we are sure the trueExpression is indented
-            groupId: conditionAndTrueExpressionGroup.id
-          }
+          // We only add `fillTab` if we are sure the trueExpression is
+          // indented.
+          { groupId }
         )
   ];
 

src/slang-printers/create-binary-operation-printer.ts

@@ -23,15 +23,13 @@ function rightOperandPrint(
       ? [` ${node.operator}`, line, path.call(print, 'rightOperand')]
       : [line, `${node.operator} `, path.call(print, 'rightOperand')];
 
-  // If it's a single binary operation, avoid having a small right
-  // operand like - 1 on its own line
+  // If there's only a single binary expression, we want to create a group in
+  // order to avoid having a small right part like -1 be on its own line.
   const leftOperand = node.leftOperand.variant;
   const grandparentNode = path.grandparent as StrictAstNode;
   const shouldGroup =
-    !(
-      leftOperand.kind !== TerminalKind.Identifier &&
-      isBinaryOperation(leftOperand)
-    ) &&
+    (leftOperand.kind === TerminalKind.Identifier ||
+      !isBinaryOperation(leftOperand)) &&
     (!isBinaryOperation(grandparentNode) ||
       grandparentNode.kind === NonterminalKind.AssignmentExpression);