use the node and grandparent getters instead of getNode() and getNode(2)

Author: Janther

src/slang-comments/printer.ts

@@ -4,7 +4,7 @@ import type { AstPath, Doc } from 'prettier';
 import type { AstNode } from '../slang-nodes/types.d.ts';
 
 export function printComment(commentPath: AstPath<AstNode>): Doc {
-  const comment = commentPath.getNode()!;
+  const comment = commentPath.node;
 
   if (isComment(comment)) {
     return comment.print();

src/slang-nodes/ConditionalExpression.ts

@@ -24,7 +24,7 @@ function experimentalTernaries(
   print: PrintFunction,
   options: ParserOptions<AstNode>
 ): Doc {
-  const grandparent = path.getNode(2) as StrictAstNode;
+  const grandparent = path.grandparent as StrictAstNode;
   const isNested = grandparent.kind === NonterminalKind.ConditionalExpression;
   const isNestedAsTrueExpression =
     isNested && grandparent.trueExpression.variant === node;
@@ -87,7 +87,7 @@ function traditionalTernaries(
     indent([
       // Nested trueExpression and falseExpression are always printed in a new
       // line
-      (path.getNode(2) as StrictAstNode).kind ===
+      (path.grandparent as StrictAstNode).kind ===
       NonterminalKind.ConditionalExpression
         ? hardline
         : line,

src/slang-printers/create-binary-operation-printer.ts

@@ -26,7 +26,7 @@ function rightOperandPrint(
   // If it's a single binary operation, avoid having a small right
   // operand like - 1 on its own line
   const leftOperand = node.leftOperand.variant;
-  const grandparentNode = path.getNode(2) as StrictAstNode;
+  const grandparentNode = path.grandparent as StrictAstNode;
   const shouldGroup =
     !(
       leftOperand.kind !== TerminalKind.Identifier &&

src/slang-printers/print-binary-operation.ts

@@ -18,7 +18,7 @@ export const binaryGroupRulesBuilder =
   (shouldGroup: (node: BinaryOperation) => boolean) =>
   (path: AstPath<BinaryOperation>) =>
   (document: Doc): Doc => {
-    const grandparentNode = path.getNode(2) as StrictAstNode;
+    const grandparentNode = path.grandparent as StrictAstNode;
     if (!isBinaryOperation(grandparentNode)) return group(document);
     if (shouldGroup(grandparentNode)) return group(document);
     return document;
@@ -44,7 +44,7 @@ export const binaryIndentRulesBuilder =
   (shouldIndent: (node: BinaryOperation) => boolean) =>
   (path: AstPath<BinaryOperation>) =>
   (document: Doc): Doc => {
-    let node = path.getNode() as StrictAstNode;
+    let node = path.node;
     for (let i = 2; ; i += 2) {
       const grandparentNode = path.getNode(i) as StrictAstNode;
       if (shouldNotIndent(grandparentNode, path, i)) break;

src/slang-printers/print-comments.ts

@@ -12,7 +12,7 @@ export function printComments(path: AstPath<AstNode>): Doc[] {
   const document = joinExisting(
     line,
     path.map((commentPath) => {
-      const comment = commentPath.getNode()!;
+      const comment = commentPath.node;
       if (comment.trailing || comment.leading || comment.printed) {
         return '';
       }

src/slang-printers/print-logical-operation.ts

@@ -21,7 +21,7 @@ const logicalGroupRulesBuilder = binaryGroupRulesBuilder(() => false);
 const logicalIndentRulesBuilder =
   (path: AstPath<BinaryOperation>, options: ParserOptions<AstNode>) =>
   (document: Doc): Doc => {
-    let node = path.getNode() as StrictAstNode;
+    let node = path.node;
     for (let i = 2; ; i += 2) {
       const grandparentNode = path.getNode(i) as StrictAstNode;
       if (shouldNotIndent(grandparentNode, path, i)) break;

src/slang-printers/print-preserving-empty-lines.ts

@@ -18,7 +18,7 @@ export function printPreservingEmptyLines(
   options: ParserOptions<AstNode>
 ): Doc {
   return path.map((childPath) => {
-    const node = childPath.getNode() as StrictAstNode;
+    const node = childPath.node as StrictAstNode;
 
     return [
       // Only attempt to prepend an empty line if `node` is not the first item

src/slangPrinter.ts

@@ -20,7 +20,7 @@ function hasNodeIgnoreComment(node: StrictAstNode): boolean {
 }
 
 function ignoreComments(path: AstPath<AstNode>): void {
-  const node = path.getNode();
+  const node = path.node;
   // We ignore anything that is not an object
   if (node === null || typeof node !== 'object') return;
 
@@ -36,7 +36,7 @@ function ignoreComments(path: AstPath<AstNode>): void {
       // The key `comments` will contain every comment for this node
       case 'comments':
         path.each((commentPath) => {
-          const comment = commentPath.getNode()!;
+          const comment = commentPath.node;
           comment.printed = true;
         }, 'comments');
         break;
@@ -61,7 +61,7 @@ function genericPrint(
   options: ParserOptions<AstNode>,
   print: PrintFunction
 ): Doc {
-  const node = path.getNode();
+  const node = path.node;
 
   if (node === null) {
     return '';

tests/unit/comments/printer.test.js

@@ -1,9 +1,7 @@
 import { printComment } from '../../../src/slang-comments/printer.ts';
 
 test('given an unknown comment type then printComment function should throw', () => {
-  const mockCommentPath = {
-    getNode: () => ({ type: 'UnknownComment', range: [0, 1] })
-  };
+  const mockCommentPath = { node: { type: 'UnknownComment', range: [0, 1] } };
 
   expect(() => {
     printComment(mockCommentPath);