fix(cache): Include mutable layer in cost calculation#22
Merged
darkcoderrises merged 1 commit intopredictable-labs:mainfrom Oct 22, 2025
Merged
fix(cache): Include mutable layer in cost calculation#22darkcoderrises merged 1 commit intopredictable-labs:mainfrom
darkcoderrises merged 1 commit intopredictable-labs:mainfrom
Conversation
ee214b7 to
1bbdc74
Compare
Collaborator
|
Minor change asked for. Thanks a lot for the fix. |
1bbdc74 to
97204c2
Compare
darkcoderrises
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included the size of the mutable layer in the cost calculation. Also included some more struct variables in the size calculation. This brings the configured size much closer to the actual size. With this change the occupied memory of Dgraph increases linearly, when changing the cache size. Before it exploded with cache-size higher than 4096.
Increased the default cache size to 4096 MiB, which should be similar a cache size of 1024 without this change.
Below are results from experiments with the cache size.
size-mb=1024
Dgraph process occupies up to 3.7 GiB of memory
heap:
size-mb=2048
Dgraph process occupies up to 5.4 GiB of memory
heap:
size-mb=4096
Dgraph process occupies up to 8.4 GiB of memory
heap:
size-mb:8192
Dgraph process occupies up to 13.3 GiB of memory
heap: