Skip to content

Revert "Cache desktop build assets in CI and release workflows"#2568

Merged
juliusmarminge merged 1 commit intomainfrom
revert-2543-t3code/blacksmith-artifact-cache
May 6, 2026
Merged

Revert "Cache desktop build assets in CI and release workflows"#2568
juliusmarminge merged 1 commit intomainfrom
revert-2543-t3code/blacksmith-artifact-cache

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented May 6, 2026

Reverts #2543

CleanShot 2026-05-06 at 15 59 42@2x

Note

Medium Risk
Touches CI/release workflows for caching and release artifact handoff; failures here can break builds or publishing even though no application code changes.

Overview
Reverts the previous approach of caching desktop build assets across jobs and instead uses GitHub Artifacts to pass desktop release outputs from the build matrix to the release job.

In ci.yml, replaces separate actions/cache/restore + conditional actions/cache/save steps with single actions/cache steps for Bun/Turbo and Playwright, removing the explicit save phases.

In release.yml, collects build outputs into release-publish/, uploads them via actions/upload-artifact, and later downloads/merges them via actions/download-artifact (removing the per-platform cache restore + staging logic).

Reviewed by Cursor Bugbot for commit 11c8fa7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Revert desktop build asset caching to use upload/download artifact steps in CI and release workflows

  • Reverts the previously cached CI build approach: ci.yml switches back to unified actions/cache@v5 steps (combined restore/save) for Bun/Turbo and Playwright caches, removing separate restore and save steps.
  • In release.yml, the build matrix job now uploads artifacts via actions/upload-artifact@v7 into a flat release-publish directory instead of saving to cache; the step errors if no files are found.
  • The publish_cli job now downloads all desktop-* artifacts via actions/download-artifact@v8 with merge-multiple: true directly into release-assets, replacing four separate cache restore steps and an intermediate staging copy.

Macroscope summarized 11c8fa7.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e13acfa7-e4c6-49d8-b023-286bc9abcd58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-2543-t3code/blacksmith-artifact-cache

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label May 6, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) May 6, 2026 23:00
@github-actions github-actions Bot added the size:L 100-499 changed lines (additions + deletions). label May 6, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 6, 2026

Approvability

Verdict: Approved

This revert PR only modifies CI workflow files (.github/workflows/ci.yml and release.yml), changing caching and artifact passing strategies without affecting any production code or runtime behavior.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit a74ed8e into main May 6, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the revert-2543-t3code/blacksmith-artifact-cache branch May 6, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant