Revert "Cache desktop build assets in CI and release workflows"#2568
Conversation
This reverts commit 6c79039.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This revert PR only modifies CI workflow files (.github/workflows/ci.yml and release.yml), changing caching and artifact passing strategies without affecting any production code or runtime behavior. You can customize Macroscope's approvability policy. Learn more. |
Reverts #2543
Note
Medium Risk
Touches CI/release workflows for caching and release artifact handoff; failures here can break builds or publishing even though no application code changes.
Overview
Reverts the previous approach of caching desktop build assets across jobs and instead uses GitHub Artifacts to pass desktop release outputs from the
buildmatrix to thereleasejob.In
ci.yml, replaces separateactions/cache/restore+ conditionalactions/cache/savesteps with singleactions/cachesteps for Bun/Turbo and Playwright, removing the explicit save phases.In
release.yml, collects build outputs intorelease-publish/, uploads them viaactions/upload-artifact, and later downloads/merges them viaactions/download-artifact(removing the per-platform cache restore + staging logic).Reviewed by Cursor Bugbot for commit 11c8fa7. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Revert desktop build asset caching to use upload/download artifact steps in CI and release workflows
actions/cache@v5steps (combined restore/save) for Bun/Turbo and Playwright caches, removing separate restore and save steps.buildmatrix job now uploads artifacts viaactions/upload-artifact@v7into a flatrelease-publishdirectory instead of saving to cache; the step errors if no files are found.publish_clijob now downloads alldesktop-*artifacts viaactions/download-artifact@v8withmerge-multiple: truedirectly intorelease-assets, replacing four separate cache restore steps and an intermediate staging copy.Macroscope summarized 11c8fa7.