Skip to content

feat(web): make auto-create PR on push optional#2524

Open
imabdulazeez wants to merge 4 commits intopingdotgg:mainfrom
imabdulazeez:feat/toggle-auto-pr-creation
Open

feat(web): make auto-create PR on push optional#2524
imabdulazeez wants to merge 4 commits intopingdotgg:mainfrom
imabdulazeez:feat/toggle-auto-pr-creation

Conversation

@imabdulazeez
Copy link
Copy Markdown
Contributor

@imabdulazeez imabdulazeez commented May 5, 2026

What Changed

Adds a client setting "Auto-create PR on push" (default on, preserves current behaviour). When switched off, the commit button on a feature branch with no open PR drops the PR step:

  • Commit, push & PRCommit & push
  • Push & create PRPush

Pushing to the default branch, pushing into an existing open PR, and the standalone Create PR affordance (when a clean branch is only ahead of default) are unchanged. The dropdown menu still exposes a separate Create PR entry, so opening a PR later is one click.

Why

Right now, on a feature branch with uncommitted changes (or just commits to push), the quick action insists on opening a PR alongside the push. That's the right default for a lot of workflows, but not all — sometimes you want to push a WIP branch, share the ref, and only open a PR once it's actually ready for review. Today the only way to do that is to use the dropdown each time, which adds friction to the common case.

This makes it a one-time toggle in settings rather than a per-push decision.

UI Changes

New row in General settings, next to the existing workflow toggles (Auto-open task panel, etc.). No change to the commit button itself when the setting is left at its default.

Screenshots

Before (PR button)

image

After (Settings toggle and PR button)

image
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes (n/a)

Note

Add opt-in toggle to disable auto-create PR on push

  • Adds autoCreatePrOnPush boolean to ClientSettingsSchema (default true) and exposes a toggle in the General settings panel.
  • resolveQuickAction in GitActionsControl.logic.ts accepts a new autoCreatePr parameter; when false, it returns Commit & push or Push instead of Commit, push & PR or Push & create PR.
  • GitActionsControl.tsx reads autoCreatePrOnPush from settings and passes it to resolveQuickAction.
  • Behavioral Change: existing users are unaffected (default is true), but toggling the setting off removes PR-creation from the quick action button.

Macroscope summarized cd3500b.

- Add client setting `autoCreatePrOnPush` (default on)
- Downgrade feature-branch quick actions to commit/push only when off
- Expose toggle in General settings
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dcd1533b-9d35-4214-9fd6-2c6db9f8b52b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels May 5, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 5, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 5, 2026

Approvability

Verdict: Approved

This PR adds a simple user preference toggle to make auto-PR creation optional on push. The default preserves existing behavior, changes are well-tested, and the scope is self-contained with no security or breaking change implications.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review May 6, 2026 04:44

Dismissing prior approval to re-evaluate 213a279

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 6, 2026
Adds default value for new setting to keep tests passing
@macroscopeapp macroscopeapp Bot dismissed their stale review May 6, 2026 05:51

Dismissing prior approval to re-evaluate 957a626

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 6, 2026
@macroscopeapp macroscopeapp Bot dismissed their stale review May 6, 2026 06:02

Dismissing prior approval to re-evaluate cd3500b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant