Skip to content

Split tags per registry in image merge step#149

Closed
yubiuser wants to merge 1 commit intomasterfrom
fix/buildx2
Closed

Split tags per registry in image merge step#149
yubiuser wants to merge 1 commit intomasterfrom
fix/buildx2

Conversation

@yubiuser
Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

Same as pi-hole/docker-pi-hole#2005.

After updating buildx to 0.31.1 our image merge workflow broke.

After a very good discussion here with the maintainers of buildx, it turned out, that our workflow always just worked due to a bug.
During the discussion, a workaround was suggested by splitting the tags on per-registry basis. This is what this PR implements. This is based on a suggestion by crazy-max.

This supersedes #140


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Copy link
Copy Markdown
Member Author

Superseded by #152

@yubiuser yubiuser closed this Mar 30, 2026
@PromoFaux PromoFaux deleted the fix/buildx2 branch April 5, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant