Skip to content

Simplify ON keyword check to only needed case #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
predictor2718 wants to merge 2 commits into
base: 5.11.x
Choose a base branch
from
+6 −1

Fix phpcs: place if condition on single line

0bd40a6
Select commit
Loading
Failed to load commit list.
Open

Simplify ON keyword check to only needed case #652

Fix phpcs: place if condition on single line
0bd40a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 13, 2026 in 0s

96.90% (-0.02%) compared to 4c45eac

View this Pull Request on Codecov

96.90% (-0.02%) compared to 4c45eac

Details

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.90%. Comparing base (4c45eac) to head (0bd40a6).

Files with missing lines Patch % Lines
src/Components/SetOperation.php 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             5.11.x     #652      +/-   ##
============================================
- Coverage     96.92%   96.90%   -0.02%     
- Complexity     2316     2319       +3     
============================================
  Files            71       71              
  Lines          5110     5112       +2     
============================================
+ Hits           4953     4954       +1     
- Misses          157      158       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov