Skip to content

feat(bench): route PR benchmarks through txgen#23869

Draft
onbjerg wants to merge 13 commits intomainfrom
txgen-pr-bench
Draft

feat(bench): route PR benchmarks through txgen#23869
onbjerg wants to merge 13 commits intomainfrom
txgen-pr-bench

Conversation

@onbjerg
Copy link
Copy Markdown
Collaborator

@onbjerg onbjerg commented Apr 30, 2026

Replaces the normal PR benchmark path in bench.yml with a txgen-backed Engine API replay while keeping big-block benchmarks on the existing reth-bench path. Adds txgen install/build/run scripts plus a JSON-to-CSV adapter so existing summaries, charts, Slack notifications, and comments continue to work.

Missing before full migration: txgen support for wait-time pacing, microsecond client-side FCU timing, and reth-bb big-block/env-switch/BAL replay.

@github-project-automation github-project-automation Bot moved this to Backlog in Reth Tracker Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@paradigmxyz paradigmxyz deleted a comment from decofe Apr 30, 2026
@decofe
Copy link
Copy Markdown
Member

decofe commented Apr 30, 2026

cc @onbjerg

✅ Benchmark complete! View job

Benchmark Results

Metric main txgen-pr-bench Change
Mean 45.32ms 44.77ms -1.20% ⚪ (±11.25%)
StdDev 57.52ms 51.98ms
P50 32.25ms 34.11ms +5.76% ⚪ (±10.67%)
P90 69.72ms 65.02ms -6.74% ⚪ (±58.58%)
P99 411.27ms 367.55ms -10.63% ✅ (±9.32%)
Mgas/s 904.37 885.36 -2.10% ⚪ (±7.38%)
Wall Clock 2.28s 2.25s -1.33% ⚪ (±11.32%)
Persist Wait 25.20ms 23.83ms -5.44% ⚪ (±88.59%)

50 blocks, 10 warmup

Wait Time Breakdown

Persistence Wait

Metric main txgen-pr-bench
Mean 25.20ms 23.83ms
P50 0.02ms 0.02ms
P95 309.46ms 198.07ms

Trie Cache Update Wait

Metric main txgen-pr-bench
Mean 0.36ms 0.43ms
P50 0.00ms 0.00ms
P95 1.76ms 1.83ms

Execution Cache Update Wait

Metric main txgen-pr-bench
Mean 0.00ms 0.00ms
P50 0.00ms 0.00ms
P95 0.00ms 0.00ms

Grafana Dashboard

Charts

Latency, Throughput & Diff

Latency, Throughput & Diff

Wait Time Breakdown

Wait Time Breakdown

Gas vs Latency

Gas vs Latency

Grafana Dashboard

View real-time metrics

@decofe
Copy link
Copy Markdown
Member

decofe commented Apr 30, 2026

cc @onbjerg

✅ Benchmark complete! View job

Benchmark Results

Metric main txgen-pr-bench Change
Mean 45.78ms 46.81ms +2.25% ⚪ (±6.87%)
StdDev 51.08ms 54.72ms
P50 34.80ms 36.52ms +4.96% ⚪ (±11.19%)
P90 69.43ms 68.94ms -0.70% ⚪ (±21.56%)
P99 372.45ms 414.06ms +11.17% ❌ (±7.32%)
Mgas/s 855.68 844.66 -1.29% ⚪ (±6.04%)
Wall Clock 4.62s 4.71s +1.99% ⚪ (±6.86%)
Persist Wait 21.80ms 21.59ms -0.95% ⚪ (±117.36%)

50 blocks, 10 warmup

Wait Time Breakdown

Persistence Wait

Metric main txgen-pr-bench
Mean 21.80ms 21.59ms
P50 0.02ms 0.02ms
P95 250.29ms 179.99ms

Trie Cache Update Wait

Metric main txgen-pr-bench
Mean 0.32ms 0.36ms
P50 0.00ms 0.00ms
P95 1.96ms 1.89ms

Execution Cache Update Wait

Metric main txgen-pr-bench
Mean 0.00ms 0.00ms
P50 0.00ms 0.00ms
P95 0.00ms 0.00ms

Grafana Dashboard

Charts

Latency, Throughput & Diff

Latency, Throughput & Diff

Wait Time Breakdown

Wait Time Breakdown

Gas vs Latency

Gas vs Latency

Grafana Dashboard

View real-time metrics

@decofe
Copy link
Copy Markdown
Member

decofe commented Apr 30, 2026

cc @onbjerg

✅ Benchmark complete! View job

Benchmark Results

Metric main txgen-pr-bench Change
Mean 257.58ms 255.84ms -0.68% ⚪ (±1.81%)
StdDev 165.07ms 160.11ms
P50 206.99ms 211.20ms +2.04% ⚪ (±7.94%)
P90 418.08ms 422.77ms +1.12% ⚪ (±8.12%)
P99 773.15ms 757.91ms -1.97% ⚪ (±3.41%)
Mgas/s 134.15 134.25 +0.07% ⚪ (±1.75%)
Wall Clock 12.89s 12.82s -0.58% ⚪ (±1.80%)
Persist Wait 0.28ms 0.19ms -30.41% ⚪ (±78.39%)

50 blocks, 10 warmup

Wait Time Breakdown

Persistence Wait

Metric main txgen-pr-bench
Mean 0.28ms 0.19ms
P50 0.02ms 0.02ms
P95 1.82ms 1.50ms

Trie Cache Update Wait

Metric main txgen-pr-bench
Mean 0.00ms 0.00ms
P50 0.00ms 0.00ms
P95 0.00ms 0.00ms

Execution Cache Update Wait

Metric main txgen-pr-bench
Mean 0.00ms 0.00ms
P50 0.00ms 0.00ms
P95 0.00ms 0.00ms

Grafana Dashboard

Charts

Latency, Throughput & Diff

Latency, Throughput & Diff

Wait Time Breakdown

Wait Time Breakdown

Gas vs Latency

Gas vs Latency

Grafana Dashboard

View real-time metrics

@decofe
Copy link
Copy Markdown
Member

decofe commented Apr 30, 2026

cc @onbjerg

✅ Benchmark complete! View job

Benchmark Results

Metric main txgen-pr-bench Change
Mean 27.02ms 26.85ms -0.64% ⚪ (±1.72%)
StdDev 16.80ms 17.13ms
P50 23.64ms 23.38ms -1.12% ⚪ (±2.06%)
P90 39.70ms 39.65ms -0.13% ⚪ (±3.88%)
P99 93.33ms 94.17ms +0.89% ⚪ (±42.08%)
Mgas/s 1164.29 1176.77 +1.07% ✅ (±1.04%)
Wall Clock 27.24s 27.07s -0.63% ⚪ (±1.74%)
Persist Wait 28.27ms 28.82ms +1.95% ⚪ (±19.20%)

500 blocks, 200 warmup

Wait Time Breakdown

Persistence Wait

Metric main txgen-pr-bench
Mean 28.27ms 28.82ms
P50 0.02ms 0.02ms
P95 263.12ms 263.83ms

Trie Cache Update Wait

Metric main txgen-pr-bench
Mean 0.55ms 0.44ms
P50 0.13ms 0.07ms
P95 2.45ms 1.71ms

Execution Cache Update Wait

Metric main txgen-pr-bench
Mean 0.00ms 0.00ms
P50 0.00ms 0.00ms
P95 0.00ms 0.00ms

Grafana Dashboard

Charts

Latency, Throughput & Diff

Latency, Throughput & Diff

Wait Time Breakdown

Wait Time Breakdown

Gas vs Latency

Gas vs Latency

Grafana Dashboard

View real-time metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants