perf(engine): use Entry API in insert_executed#23842
Open
wataxiwajojo wants to merge 1 commit intoparadigmxyz:mainfrom
Open
perf(engine): use Entry API in insert_executed#23842wataxiwajojo wants to merge 1 commit intoparadigmxyz:mainfrom
insert_executed#23842wataxiwajojo wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
Replace `contains_key` + `insert` in `TreeState::insert_executed` with a single `entry()` match, dropping the duplicate hash lookup on every block insertion. Matches the pattern already used in `remove_by_hash` and `block_buffer::insert_block`.
wataxiwajojo
requested review from
Rjected,
mattsse and
mediocregopher
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
contains_key+insertinTreeState::insert_executedwith a singleentry()match, dropping the duplicate hash lookup on every block insertion. Matches the pattern already used inremove_by_hashandblock_buffer::insert_block.