Fix crash on non-integer value argument (#2)#3
Open
p0dalirius wants to merge 1 commit intomainfrom
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #2
Root Cause
The
valueargparse argument is taken as a raw string and fed directly intoint(options.value)at two sites in the__main__block without any surrounding error handling. Any string that is not a valid base-10 integer literal (e.g.0x220,abc) therefore raises an uncaughtValueErrorand the interpreter prints a traceback.Fix Description
Move the
int(options.value)conversion out of each attribute branch and into a singletryblock that runs immediately afterparseArgs(). OnValueErrorthe program now prints a clear[!] Invalid value ...: expected an integermessage and exits with status code1. The attribute branches keep their existing behaviour and are now reached only when the value is a valid integer.How Verified
Runtime checks before and after the patch:
Before:
After:
Test Coverage
None: repository has no automated test suite; the fix is verified by the runtime checks above. Adding a test harness is out of scope for this bug fix.
Scope of Change
msFlagsDecoder.pyRisk and Rollout
Local change limited to the CLI entry point. The only behavioural difference for previously-accepted inputs is that the integer parse happens one step earlier, which is observationally equivalent. Safe to merge without staged rollout.