fix contains_cycle false positive on raw string prefix#22
Merged
sunshowers merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/fix-contains_cycle-false-positive-on-raw-string-prefix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect cycles by checking for path segments (with a trailing
/) rather than just using a raw string prefix. We hit this in Omicron whereAuditLogEntrywas incorrectly detected as a prefix ofAuditLogEntryActor, hiding incompatible changes.This is a minimal fix that (I believe) is correct given the current structure. I'm reworking this in #15 to have stronger types so we can think about this in a more principled manner.