Skip to content

Improve instance dump for jail#23

Open
AlexeyAndKartashov wants to merge 1 commit intoopenwrt:masterfrom
AlexeyAndKartashov:patch-2
Open

Improve instance dump for jail#23
AlexeyAndKartashov wants to merge 1 commit intoopenwrt:masterfrom
AlexeyAndKartashov:patch-2

Conversation

@AlexeyAndKartashov
Copy link
Copy Markdown
Contributor

mount and setns properties apply exclusively to jail data.
But in instance dump they are displayed as if they relate directly to the instance properties:

$ ubus call service list '{"name": "sysntpd"}'
{
        "sysntpd": {
                "instances": {
                        "instance1": {
                                "running": true,
                                "pid": 7405,
                                "command": [
                                        "/usr/sbin/ntpd",
                                        "-n",
                                        "-N",
                                        "-S",
                                        "/usr/sbin/ntpd-hotplug",
                                        "-p",
                                        "0.openwrt.pool.ntp.org",
                                        "-p",
                                        "1.openwrt.pool.ntp.org",
                                        "-p",
                                        "2.openwrt.pool.ntp.org",
                                        "-p",
                                        "3.openwrt.pool.ntp.org"
                                ],
                                "term_timeout": 5,
                                "respawn": {
                                        "threshold": 3600,
                                        "timeout": 5,
                                        "retry": 5
                                },
                                "no_new_privs": true,
                                "capabilities": "/etc/capabilities/ntpd.json",
                                "user": "ntp",
                                "group": "ntp",
                                "jail": {
                                        "name": "ntpd",
                                        "procfs": false,
                                        "sysfs": false,
                                        "ubus": true,
                                        "log": false,
                                        "ronly": false,
                                        "netns": false,
                                        "userns": false,
                                        "cgroupsns": false,
                                        "console": false
                                },
                                "mount": {
                                        "/bin/ubus": "0",
                                        "/usr/bin/env": "0",
                                        "/usr/bin/jshn": "0",
                                        "/usr/sbin/ntpd-hotplug": "0",
                                        "/usr/share/libubox/jshn.sh": "0"
                                }
                        }
                }
        }
}

@dangowrt
Copy link
Copy Markdown
Member

dangowrt commented Feb 9, 2026

While the pull request has a full description, the commit message itself contains only a title.
Please also include a full description in the commit message, you may (and maybe should) skip the same output.

@aparcar
Copy link
Copy Markdown
Member

aparcar commented Apr 16, 2026

@dangowrt do you mind fixing it while committing? would be a bummer not to have this patch

@AlexeyAndKartashov AlexeyAndKartashov force-pushed the patch-2 branch 2 times, most recently from d4c7678 to d220a33 Compare April 17, 2026 05:52
`mount` and `setns` properties apply exclusively to jail data.

But in instance dump they are displayed as if they relate directly to the instance properties
@AlexeyAndKartashov
Copy link
Copy Markdown
Contributor Author

@dangowrt Sorry, I completely forgot about your request to correct the commit. Done

@dangowrt
Copy link
Copy Markdown
Member

dangowrt commented May 4, 2026

Please add your Signed-off-by:-tag,, and also avoid lines longer than 70 characters in commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants