feat: r2 adapter for the incremental cache#443
Merged
james-elicx merged 20 commits intomainfrom Mar 21, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 33c238b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Mar 9, 2025
ced3fcf to
de7e0bb
Compare
conico974
reviewed
Mar 13, 2025
de7e0bb to
76e2c5d
Compare
Collaborator
Author
Yeah I think the main outstanding questions are;
I was hoping to be able to talk about those this week, but didn't realise that the meeting time was changing 😓. Hopefully Victor might have a chance to take a look at the PRs at some point, otherwise we can discuss next week I guess, but I was hoping to have wrapped up the population one by now. |
vicb
reviewed
Mar 20, 2025
conico974
reviewed
Mar 20, 2025
vicb
reviewed
Mar 21, 2025
vicb
reviewed
Mar 21, 2025
vicb
reviewed
Mar 21, 2025
conico974
approved these changes
Mar 21, 2025
Collaborator
conico974
left a comment
There was a problem hiding this comment.
LGTM, just a small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based off of #436 to enable auto-populating of the cache entries.
Changes
Discussion points
This is part 2 of 3 in a stack made with GitButler: