Skip to content

Add packageManager field and update workflow actions#1216

Merged
vicb merged 4 commits intoopennextjs:mainfrom
314systems:package-manager
Apr 28, 2026
Merged

Add packageManager field and update workflow actions#1216
vicb merged 4 commits intoopennextjs:mainfrom
314systems:package-manager

Conversation

@314systems
Copy link
Copy Markdown
Contributor

This pull request updates several GitHub Actions workflows and related configuration to use the latest versions of key GitHub Actions and tools, improving security, compatibility, and performance. It also explicitly sets the pnpm package manager version in package.json for better reproducibility.

GitHub Actions version upgrades:

  • Updated actions/checkout to version 6 in all workflows.
  • Upgraded actions/setup-node to version 6 and pnpm/action-setup to version 5 in the install-dependencies action.
  • Upgraded actions/cache to version 5 in the setup-playwright action.
  • Updated actions/upload-artifact to version 7 in the Playwright workflow for artifact uploads.

Tooling and configuration updates:

  • Added the packageManager field to package.json, explicitly specifying [email protected] with a lockfile hash for improved dependency management and reproducibility.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: f2c9f13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 21, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1216

commit: f2c9f13

@314systems
Copy link
Copy Markdown
Contributor Author

By specifying a fixed packageManager in the project, it is possible to eliminate differences caused by variations in pnpm versions. (For example: 0958726)

packageManager with pnpm automatically determines the pnpm version for CI.
https://github.com/pnpm/action-setup#install-only-pnpm-with-packagemanager

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I'm +1 to use a fixed varsion of pnpm and updating the GH actions.

@conico974 @james-elicx @sommeeeer any thoughts about this PR?

Copy link
Copy Markdown
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@314systems
Copy link
Copy Markdown
Contributor Author

314systems commented Apr 28, 2026

https://github.com/pnpm/pnpm/releases/tag/v10.33.2
https://github.com/pnpm/pnpm/releases/tag/v10.33.1

pnpm 10.33.2 was released a few days ago. Should I update to the latest version?

(Already merged, feel free to bump it.)

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Apr 28, 2026

Thanks @314systems for the PR and @james-elicx and @conico974 for the feedback!

@vicb vicb merged commit 1b8ff91 into opennextjs:main Apr 28, 2026
7 checks passed
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Apr 28, 2026

https://github.com/pnpm/pnpm/releases/tag/v10.33.2 https://github.com/pnpm/pnpm/releases/tag/v10.33.1

pnpm 10.33.2 was released a few days ago. Should I update to the latest version?

Sorry I only saw this message after I merged the PR.
I think it's ok as is - some devs decide to respect a quarantine period before using a new version.

@314systems 314systems deleted the package-manager branch April 28, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants