Fix tag cache stale logic and update tests#1193
Conversation
🦋 Changeset detectedLatest commit: 5d99b42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
left a comment
There was a problem hiding this comment.
@conico974 I have added a few minor comments, could you please take a look and let me know what you think.
Changes otherwise look good so I can update the PR when I get your feedback and get that merged.
Thanks!
vicb
left a comment
There was a problem hiding this comment.
The build is broken by my last commit (looks like nextVersion is undefined).
I'll take a look and fix
|
The build issue was related to |
vicb
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot @conico974 !
Update the stale logic in the tag cache to consider the
revalidatedAttimestamp, ensuring accurate cache validation.It doesn't technically require the bump of aws