feat: replace enterprise_support import with GradeEventContextRequested filter#38097
Open
feat: replace enterprise_support import with GradeEventContextRequested filter#38097
Conversation
kiram15
force-pushed
the
pwnage101/ENT-11563
branch
from
8a889ec to
4c2d441
Compare
kiram15
force-pushed
the
pwnage101/ENT-11563
branch
from
038a651 to
d11c292
Compare
kdmccormick
requested changes
May 5, 2026
Member
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Thanks for this work! I think we can avoid adding more complexity to production.py, though, no?
kiram15
force-pushed
the
pwnage101/ENT-11563
branch
3 times, most recently
from
fa66d0b to
2ad7aa1
Compare
pwnage101
commented
May 5, 2026
kiram15
force-pushed
the
pwnage101/ENT-11563
branch
2 times, most recently
from
18f9d8b to
22f0eb2
Compare
…ed filter Removes the direct import of get_enterprise_event_context from openedx.features.enterprise_support.context in grades/events.py and replaces it with a call to the GradeEventContextRequested openedx-filter. Adds the filter to OPEN_EDX_FILTERS_CONFIG with the GradeEventContextEnricher pipeline step. Updates tests to mock the filter instead of the enterprise function. ENT-11563 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
kiram15
force-pushed
the
pwnage101/ENT-11563
branch
from
22f0eb2 to
cacd853
Compare
pwnage101
commented
May 5, 2026
Comment on lines
+3296
to
+3298
| "org.openedx.learning.grade.context.requested.v1": { | ||
| "fail_silently": False, | ||
| "pipeline": ["enterprise.filters.dashboard.DashboardContextEnricher"], |
Contributor
Author
There was a problem hiding this comment.
❌ Now the filter and the pipeline step are incompatible. I think you meant to include GradeEventContextEnricher, not DashboardContextEnricher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the direct import of get_enterprise_event_context from openedx.features.enterprise_support.context in grades/events.py and replaces it with a call to the GradeEventContextRequested openedx-filter. Adds the filter to OPEN_EDX_FILTERS_CONFIG with the GradeEventContextEnricher pipeline step. Updates tests to mock the filter instead of the enterprise function.
ENT-11563
Co-Authored-By: Claude Sonnet 4.6 [email protected]
Blocked by: