feat: REST_API to get MAX_BLOCKS_PER_CONTENT_LIBRARY [FC-0112]#37686
feat: REST_API to get MAX_BLOCKS_PER_CONTENT_LIBRARY [FC-0112]#37686ChrisChV wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
navinkarkera
left a comment
There was a problem hiding this comment.
@ChrisChV Looks good. I wonder if there is a way to include MAX_BLOCKS_PER_CONTENT_LIBRARY setting in MFE_CONFIG, then we can directly access it in the frontend without needing another API.
I haven't found a good way to do this. It can be done in |
|
I think I would prefer to add But on the other hand, I would prefer that we don't have this information on the frontend at all. Is it not possible to do some kind of "preview import" REST request with the parameters of the import, and have the backend return warnings/errors if the import is going to fail for some reason like this? (would exceed the block limit, user doesn't have write permissions on that library, etc.) You don't have to refactor it to be this way, but that's what I would have suggested. |
|
Closed in favor of #37818 |
Description
MAX_BLOCKS_PER_CONTENT_LIBRARYSupporting information
Testing instructions
Follow the testing instructions in: openedx/frontend-app-authoring#2700
Deadline
"None"
Other information
N/A