Skip to content

feat: Add tags_count to ContainerMetadata [FC-0090]#36883

Merged
ChrisChV merged 2 commits intoopenedx:masterfrom
open-craft:chris/FAL-4175-tag-section-subsections
Jun 23, 2025
Merged

feat: Add tags_count to ContainerMetadata [FC-0090]#36883
ChrisChV merged 2 commits intoopenedx:masterfrom
open-craft:chris/FAL-4175-tag-section-subsections

Conversation

@ChrisChV
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV commented Jun 10, 2025 •
edited
Loading

Description

  • Add tags_count to ContainerMetadata.
  • Which edX user roles will this change impact? "Developer",

Supporting information

Testing instructions

Deadline

None

Other information

N/A

@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Jun 10, 2025

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 10, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 10, 2025
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jun 12, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jun 12, 2025
@mphilbrick211 mphilbrick211 moved this from In Eng Review to Ready for Review in Contributions Jun 12, 2025
@ChrisChV ChrisChV mentioned this pull request Jun 12, 2025
Merged
pomegranited
pomegranited approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works correctly thank you @ChrisChV !

  • I tested this while testing openedx/frontend-app-authoring#2136
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

Comment thread openedx/core/djangoapps/content_libraries/api/block_metadata.py
library_key,
component,
),
usage_key=usage_key,
Copy link
Copy Markdown
Contributor

@pomegranited pomegranited Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank you for spotting this!

@ChrisChV ChrisChV requested a review from bradenmacdonald June 20, 2025 19:55
@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Jun 20, 2025
@bradenmacdonald
Copy link
Copy Markdown
Contributor

bradenmacdonald commented Jun 20, 2025

@ChrisChV Jill's review here is enough to merge already, but it also looks good to me ✅

@ChrisChV ChrisChV merged commit a9abb11 into openedx:master Jun 23, 2025
49 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Jun 23, 2025
@ChrisChV ChrisChV deleted the chris/FAL-4175-tag-section-subsections branch June 23, 2025 17:10
@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

edx-pipeline-bot commented Jun 23, 2025

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

edx-pipeline-bot commented Jun 23, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

edx-pipeline-bot commented Jun 23, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

edx-pipeline-bot commented Jun 23, 2025

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

edx-pipeline-bot commented Jun 23, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Copy Markdown
Contributor

edx-pipeline-bot commented Jun 23, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

marlonkeating pushed a commit that referenced this pull request Jul 15, 2025
@ChrisChV @marlonkeating
feat: Add tags_count to ContainerMetadata (#36883)
fa83b9d
sumair-arbisoft pushed a commit to sumair-arbisoft/edx-platform that referenced this pull request Aug 5, 2025
@ChrisChV @sumair-arbisoft
feat: Add tags_count to ContainerMetadata (openedx#36883)
22f7ef3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomegranited pomegranited pomegranited approved these changes

@bradenmacdonald bradenmacdonald Awaiting requested review from bradenmacdonald

Assignees

No one assigned

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ChrisChV @openedx-webhooks @bradenmacdonald @edx-pipeline-bot @pomegranited @mphilbrick211