[FC-0099] feat: add admin configuration for CasbinRule model#138
Conversation
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Can we also include the extended model or can we see it as an inline model inside each casbin rule? |
|
Thanks for your suggestion! @mariajgrimaldi, I included the |
|
@mariajgrimaldi, should we only show the |
It's okay for now! For future visualization, we could also include the subject and scope objects. Let's leave a TODO comment for that :) |
|
Thanks! @mariajgrimaldi, I added the TODO comment. |
Description
This PR registers the
CasbinRulemodel in the Django Admin. Also linked theExtendedCasbinRulemodel to each Casbin Rule.Testing Instructions
Go to
{lms_domain}/admin/casbin_adapter/casbinrule/and see the table.Screenshots
Merge checklist:
Check off if complete or not applicable: