[FC-0099] fix: return user count of the specific scope#121
[FC-0099] fix: return user count of the specific scope#121mariajgrimaldi merged 3 commits intoopenedx:mainfrom
Conversation
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| return [ | ||
| SubjectData(namespaced_key=policy[GroupingPolicyIndex.SUBJECT.value]) | ||
| for policy in policies | ||
| if policy[GroupingPolicyIndex.SCOPE.value] == scope.namespaced_key |
There was a problem hiding this comment.
I've also had to do this a couple of times in these functions since get_filtered_grouping_policy doesn't support filtering by more than one parameter. It'd be nice if, as a future improvement, we could implement a get_filtered_grouping_policy with N parameters as input. In any case, this looks good to me!
bmtcril
left a comment
There was a problem hiding this comment.
Looks good to me, though I'm not sure if there is a use case for keeping the original around too. Should be easy enough to resurrect if we need to, though.
Description
This PR fixes the current behavior of the "list role by scope" endpoint. Previously, the user count corresponded to the total number of users in the scope, that is, the total number of users assigned to all libraries. Now, it only returns the total number of users assigned to the specific library provided in the scope query parameter.
Testing Instructions
Using Tutor:
tutor dev exec lms python manage.py lms migratetutor dev exec lms python manage.py lms load_policiesEndpoint
It should only return the count of users assigned to each role within the specified scope.
Merge Checklist:
Check off if complete or not applicable: