Skip to content

[FC-0099] feat: add admin configuration for CasbinRule model#138

Merged
mariajgrimaldi merged 8 commits intoopenedx:mainfrom
eduNEXT:bav/add-casbin-model-to-django-admin
Nov 13, 2025
Merged

[FC-0099] feat: add admin configuration for CasbinRule model#138
mariajgrimaldi merged 8 commits intoopenedx:mainfrom
eduNEXT:bav/add-casbin-model-to-django-admin

Conversation

@BryanttV
Copy link
Copy Markdown
Contributor

@BryanttV BryanttV commented Nov 11, 2025

Description

This PR registers the CasbinRule model in the Django Admin. Also linked the ExtendedCasbinRule model to each Casbin Rule.

Testing Instructions

Go to {lms_domain}/admin/casbin_adapter/casbinrule/ and see the table.

Screenshots

image image image

Merge checklist:

Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 11, 2025
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@BryanttV BryanttV changed the title feat: add admin configuration for CasbinRule model in openedx_authz [FC-0099] feat: add admin configuration for CasbinRule model Nov 11, 2025
@mariajgrimaldi
Copy link
Copy Markdown
Member

Can we also include the extended model or can we see it as an inline model inside each casbin rule?

@BryanttV
Copy link
Copy Markdown
Contributor Author

Thanks for your suggestion! @mariajgrimaldi, I included the ExtendedCasbinRule like an inline model.

@BryanttV
Copy link
Copy Markdown
Contributor Author

BryanttV commented Nov 12, 2025

@mariajgrimaldi, should we only show the ExtendedCasbinRule when the type of the rule is g? Or should we always show it (as it is now)?

@MaferMazu MaferMazu moved this to Ready for review in RBAC AuthZ Board Nov 12, 2025
Copy link
Copy Markdown
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks.

The ExtendedCasbinRule object and the subject aren't very useful right now, but for the purpose of this PR and the MVP, I think it is okay.

@mariajgrimaldi
Copy link
Copy Markdown
Member

@mariajgrimaldi, should we only show the ExtendedCasbinRule when the type of the rule is g? Or should we always show it (as it is now)?

It's okay for now! For future visualization, we could also include the subject and scope objects. Let's leave a TODO comment for that :)

@BryanttV
Copy link
Copy Markdown
Contributor Author

Thanks! @mariajgrimaldi, I added the TODO comment.

@mariajgrimaldi mariajgrimaldi merged commit 573ff65 into openedx:main Nov 13, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Nov 13, 2025
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in RBAC AuthZ Board Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants