refactor: address quality errors

Author: mariajgrimaldi

openedx_authz/api/data.py

@@ -7,7 +7,6 @@
 from opaque_keys import InvalidKeyError
 from opaque_keys.edx.locator import LibraryLocatorV2
 
-
 __all__ = [
     "UserData",
     "PermissionData",
@@ -206,7 +205,7 @@ class ScopeData(AuthZData, metaclass=ScopeMeta):
     NAMESPACE: ClassVar[str] = "sc"
 
     @classmethod
-    def validate_external_key(cls, external_key: str) -> bool:
+    def validate_external_key(cls, _: str) -> bool:
         """Validate the external_key format for ScopeData.
 
         For the base ScopeData class, we accept any external_key works. This
@@ -389,7 +388,7 @@ class RoleData(AuthZData):
     """
 
     NAMESPACE: ClassVar[str] = "role"
-    permissions: list[PermissionData] = list()
+    permissions: list[PermissionData] = []
 
     @property
     def name(self) -> str:
@@ -415,5 +414,5 @@ class RoleAssignmentData(AuthZData):
     """
 
     subject: SubjectData = None  # Needs defaults to avoid value error from attrs
-    roles: list[RoleData] = list()
+    roles: list[RoleData] = []
     scope: ScopeData = None

openedx_authz/api/permissions.py

@@ -5,13 +5,7 @@
 are not explicitly defined, but are inferred from the policy rules.
 """
 
-from openedx_authz.api.data import (
-    ActionData,
-    PermissionData,
-    PolicyIndex,
-    ScopeData,
-    SubjectData,
-)
+from openedx_authz.api.data import ActionData, PermissionData, PolicyIndex, ScopeData, SubjectData
 from openedx_authz.engine.enforcer import enforcer
 
 __all__ = [

openedx_authz/api/users.py

@@ -9,22 +9,16 @@
 (e.g., 'user@john_doe').
 """
 
-from openedx_authz.api.data import (
-    ActionData,
-    RoleAssignmentData,
-    RoleData,
-    ScopeData,
-    UserData,
-)
+from openedx_authz.api.data import ActionData, RoleAssignmentData, RoleData, ScopeData, UserData
 from openedx_authz.api.permissions import is_subject_allowed
 from openedx_authz.api.roles import (
     assign_role_to_subject_in_scope,
     batch_assign_role_to_subjects_in_scope,
     batch_unassign_role_from_subjects_in_scope,
     get_all_subject_role_assignments_in_scope,
     get_subject_role_assignments,
-    get_subject_role_assignments_in_scope,
     get_subject_role_assignments_for_role_in_scope,
+    get_subject_role_assignments_in_scope,
     unassign_role_from_subject_in_scope,
 )
 

openedx_authz/management/commands/load_policies.py

@@ -9,11 +9,12 @@
     python manage.py load_policies --policy-file-path /path/to/policy.csv
 """
 
-import casbin
 import os
-from openedx_authz import ROOT_DIRECTORY
+
+import casbin
 from django.core.management.base import BaseCommand
 
+from openedx_authz import ROOT_DIRECTORY
 from openedx_authz.engine.enforcer import enforcer as global_enforcer
 from openedx_authz.engine.utils import migrate_policy_between_enforcers
 

openedx_authz/tests/api/test_roles.py

@@ -24,12 +24,11 @@
     batch_assign_role_to_subjects_in_scope,
     get_all_subject_role_assignments_in_scope,
     get_permissions_for_active_roles_in_scope,
-    get_permissions_for_roles,
     get_permissions_for_single_role,
     get_role_definitions_in_scope,
     get_subject_role_assignments,
-    get_subject_role_assignments_in_scope,
     get_subject_role_assignments_for_role_in_scope,
+    get_subject_role_assignments_in_scope,
     unassign_role_from_subject_in_scope,
 )
 from openedx_authz.engine.enforcer import enforcer as global_enforcer

openedx_authz/tests/api/test_users.py

@@ -18,8 +18,8 @@
     get_user_role_assignments,
     get_user_role_assignments_for_role_in_scope,
     get_user_role_assignments_in_scope,
-    unassign_role_from_user,
     is_user_allowed,
+    unassign_role_from_user,
 )
 from openedx_authz.tests.api.test_roles import RolesTestSetupMixin