refactor: use is_user_allowed instead of has permission to improve consistency

Author: mariajgrimaldi

openedx_authz/api/permissions.py

@@ -17,7 +17,7 @@
 __all__ = [
     "get_permission_from_policy",
     "get_all_permissions_in_scope",
-    "has_permission",
+    "is_subject_allowed",
 ]
 
 
@@ -54,7 +54,7 @@ def get_all_permissions_in_scope(scope: ScopeData) -> list[PermissionData]:
     return [get_permission_from_policy(action) for action in actions]
 
 
-def has_permission(
+def is_subject_allowed(
     subject: SubjectData,
     action: ActionData,
     scope: ScopeData,

openedx_authz/api/users.py

@@ -16,7 +16,7 @@
     ScopeData,
     UserData,
 )
-from openedx_authz.api.permissions import has_permission
+from openedx_authz.api.permissions import is_subject_allowed
 from openedx_authz.api.roles import (
     assign_role_to_subject_in_scope,
     batch_assign_role_to_subjects_in_scope,
@@ -37,7 +37,7 @@
     "get_user_role_assignments_in_scope",
     "get_user_role_assignments_for_role_in_scope",
     "get_all_user_role_assignments_in_scope",
-    "user_has_permission",
+    "is_user_allowed",
 ]
 
 
@@ -169,7 +169,7 @@ def get_all_user_role_assignments_in_scope(
     )
 
 
-def user_has_permission(
+def is_user_allowed(
     user_external_key: str,
     action_external_key: str,
     scope_external_key: str,
@@ -184,7 +184,7 @@ def user_has_permission(
     Returns:
         bool: True if the user has the specified permission in the scope, False otherwise.
     """
-    return has_permission(
+    return is_subject_allowed(
         UserData(external_key=user_external_key),
         ActionData(external_key=action_external_key),
         ScopeData(external_key=scope_external_key),

openedx_authz/tests/api/test_users.py

@@ -19,7 +19,7 @@
     get_user_role_assignments_for_role_in_scope,
     get_user_role_assignments_in_scope,
     unassign_role_from_user,
-    user_has_permission,
+    is_user_allowed,
 )
 from openedx_authz.tests.api.test_roles import RolesTestSetupMixin
 
@@ -401,13 +401,13 @@ class TestUserPermissions(UserAssignmentsSetupMixin):
         ("peggy", "create_library_collection", "lib:Org2:physics_401", False),
     )
     @unpack
-    def test_user_has_permission(self, username, action, scope_name, expected_result):
+    def test_is_user_allowed(self, username, action, scope_name, expected_result):
         """Test checking if a user has a specific permission in a given scope.
 
         Expected result:
             - The function correctly identifies whether the user has the specified permission in the scope.
         """
-        result = user_has_permission(
+        result = is_user_allowed(
             user_external_key=username,
             action_external_key=action,
             scope_external_key=scope_name,