feat: delete confirm modal#3033
Conversation
|
Thanks for the pull request, @mgwozdz-unicon! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3033 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 1383 1386 +3
Lines 32645 32665 +20
Branches 7472 7509 +37
=======================================
+ Hits 31168 31188 +20
Misses 1408 1408
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
left a comment
There was a problem hiding this comment.
This looks great! Once the test button has been removed this should be good to merge!
| @@ -0,0 +1,119 @@ | |||
| import React from 'react'; | |||
| import userEvent from '@testing-library/user-event'; | |||
| confirmLabel: string; | ||
| cancelLabel: string; | ||
| X: string; | ||
| confirmPayload?: Record<string, any> | null; |
| </div> | ||
| </ModalDialog.Body> | ||
| <ModalDialog.Footer> | ||
| <ActionRow> |
| {intl.formatMessage(messages.typeToConfirmInstruction, { | ||
| X, | ||
| strong: (chunks: React.ReactNode) => <strong>{chunks}</strong>, | ||
| })} |
Description
This is part of openedx/modular-learning#260 - a split-out so that it's smaller PRs to review.
The intention is to have a type confirm modal for deletions, but keep the actual deletion logic separate.
Important
The test button needs to be deleted before merging this.
Testing instructions
Use of AI
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'