fix: open Roles and permissions in new tab#3027
fix: open Roles and permissions in new tab#3027jacobo-dominguez-wgu merged 4 commits intoopenedx:masterfrom
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @jesusbalderramawgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| ? [{ | ||
| href: `${getConfig().ADMIN_CONSOLE_URL}/authz?scope=${encodeURIComponent(courseId)}`, | ||
| title: intl.formatMessage(messages['header.links.roles.permissions']), | ||
| href: '#', |
There was a problem hiding this comment.
@jacobo-dominguez-wgu @rodmgwgu
right now the current component that renders these items on the menu does not support target="_blank"
so I had to do this.
currently all of these items redirect in the same tab.
The correct solution is to update
import { StudioHeader } from '@edx/frontend-component-header';
in the other repository to support this, although not sure if is worth it because this is gonna be updated to frontend-base in the near future.
I would like to know your thoughts on this.
Thank you!
There was a problem hiding this comment.
I guess we can go with it for now.
There was a problem hiding this comment.
cool, let me fix the tests, thank you
There was a problem hiding this comment.
@gviedma-aulasneo What do you think? What's the context behind the requirement for having this link open in a new tab? From the technical perspective, I would prefer not doing this solution if possible as it's not clean.
I would propose for now not changing the behaviour on the course outline, we can add a ticket to solve this in a better way on next phases.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3027 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 1381 1383 +2
Lines 32566 32597 +31
Branches 7472 7476 +4
=======================================
+ Hits 31091 31121 +30
- Misses 1406 1407 +1
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
Description
this change is part of the following merged issues
PR 1
PR 2
Change
the redirection to admin console needs to be in a new tab