feat: Asset Browser and picker for XBlocks#3013
Conversation
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
72390d9 to
d12388f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3013 +/- ##
==========================================
- Coverage 95.47% 95.43% -0.04%
==========================================
Files 1383 1384 +1
Lines 32645 32688 +43
Branches 7481 7504 +23
==========================================
+ Hits 31168 31196 +28
- Misses 1421 1423 +2
- Partials 56 69 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This creates a new "file_picker" page in the authoring MFE. This page can be used as an embedded file browser for XBlocks to use for selecting assets. When files are selected it posts a message back to the opener with the selected files so they can be used by the block.
Supporting information
This was discussed on the forums and on related issue.
Testing instructions
Currently testing this requires using an XBlock or other code running in the platform that supports this.
TBD
Other information
Some of the XBlocks here have been adapted to work with this.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'