fix: Resolve different issues and bugs

[ChrisChV]

Description

Fixes:

#2826 (comment)

"For any new content, info sidebar should be opened for the newly created object. ie: subsection is added, the subsection should be selected with the info tab open" ← This is not the case when I've collapsed everything in the course outline page. If I collapse all and then add something smaller than a section (a subsection or a unit), I don't see where that subsection or unit goes in the course outline. I would expect that if I add a subsection or a unit using the sidebar when I have everything collapsed on the Course outline page, I'd expect that the section that I just added content to would expand and I'd see the newly added thing selected. Its hard to know where the thing I just added went otherwise.

#2791 (comment)

If a course element is a descendent of a library object and the descendent now has a broken link, the right message appears AND the generic broken link message also appears, which feels redundant to me. See the screenshot, below:

#2907 (comment)

Sidebar shows a Publish button which should only be shown for Units.

#2665 (comment)

I tested this and it looks good except I did note one thing that didn't seem to fully match up with the requirements. And that is this requirement: "Sidebar state should be remembered, as in: if a section is selected with the info sidebar, settings tab open, if a user clicks a unit, the unit info, settings sidebar should open."

#2629 (comment)

This looks good to me except for one tiny nitpick that we appear to be missing in the sandbox but that exists in the design (see the count of filtered library elements shown on the add existing tab highlighted by the red outline on the screenshot from the design below). I think this is a NICE TO HAVE, but not a must have. Let me know what the lift is to add this. If it is significant, we can capture this as an improvement to be added later and we can mark this user story as complete.

#2633 (comment)

If I select a library on the Add existing tab and then I go through and select every library listed, it just shows me "N Libraries" in the dropdown menu text when I collapse the dropdown menu instead of "All Libraries" which is what I would expect to see. This is not a BIG deal, but seems to not entirely fulfill the AC. Let me know what you think. Happy to move this to done if we capture the work to update this in time...

Supporting information

• Github issues:
  • Course outline: Add sidebar updates #2826 (comment)
  • Library Reference Card #2791 (comment)
  • Conditional Components are not working properly #2907 (comment)
  • Course Outline: Make sections/subsections/units selectable #2665 (comment)
  • Course Outline: Add Sidebar basics (Add button Flow) #2629 (comment)
  • Course Outline: Filter by Library (Add Sidebar) #2633 (comment)
• Internal ticket: https://tasks.opencraft.com/browse/FAL-4338

Testing instructions

#2826 (comment)

• In the course outline create a section, collapse all the content.
• Click in the Add in the course header to open the Course add sidebar.
• Add a subsection. Verify that the section is expanded.

#2791 (comment)

• Go to a content library and create a Section > Subsection.
• Publish the library
• Go to the course outline and add the Section from the library.
• Go to the content library and delete the Subsection.
• Go to the course outline, open the info sidebar of the Subsection and check that only you can unlint the Subsection.

#2907 (comment)

• In course advanced settings, add conditional to the "Advanced module list"
• Add a Problem component and a Conditional component to your course.
• Copy the XBlock ID (block-v1:...) of the problem component. (Is there any way to do this from the UI?)
• Edit the conditional component. At the very bottom of its settings, paste the ID of the problem component.
• Save the Conditional component. Go to the Conditional component page
• Verify the sidebar, verify that the publish section is hidden.
• Verify other features of the sidebar, like adding components.

#2665 (comment)

• Go to a course, and create some Sections, Subsections, units
• Select a section to open the info sidebar.
• Open the Add sidebar of the section,
• Select a subsection, verify that the Add sidebar is open in the context of the subsection.
• Change the tab in the Add sidebar.
• Select a unit, verify that the Add sidebar is open in the previously selected tab.

#2629 (comment)

• Go to a course and open the Add sidebar.
• Go to the Add Existing tab.
• Verify that you can see Showing N Content Blocks

#2633 (comment)

• Go to a course and open the Add sidebar
• Go to the Add Existing tab.
• In the Library filter, select all libraries. Verify that the text of the button changes to All Libraries.

Other information

Merge before Verawood

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

• Any new files are using TypeScript (.ts, .tsx).
• Avoid propTypes and defaultProps in any new or modified code.
• Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
• Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
• Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
• All new i18n messages in messages.ts files have a description for translators to use.
• Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

[openedx-webhooks]

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.47%. Comparing base (9c8e672) to head (e28a6ee).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2998    +/-   ##
========================================
  Coverage   95.46%   95.47%            
========================================
  Files        1381     1381            
  Lines       32520    32563    +43     
  Branches     7426     7228   -198     
========================================
+ Hits        31044    31088    +44     
- Misses       1407     1419    +12     
+ Partials       69       56    -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bradenmacdonald]

Code looks fine to me. If @navinkarkera or @rpenido can test it and confirm it's working, I'll approve.

[bradenmacdonald]

I wonder if we should store this in the URL or in the #hash at some point in the future? I generally find that better for web UI state like which tab/modal is active. No need to change now though.

[rpenido]

Hi @ChrisChV!

I found some issues while testing:

#2907 (comment)
...
Verify other features of the sidebar, like adding components.

I can add the components using the sidebar, but using the "Add New Component" snippet on the page gives me some errors:

• I can't add Text components
• I can add a Video, but it shows the edit modal inside the iFrame

Everything else is working as expected! Good work here!
CC @bradenmacdonald

[rpenido]

I'm not sure, but I think the Settings also doesn't make sense with the conditional block here.

[ChrisChV]

I can add the components using the sidebar, but using the "Add New Component" snippet on the page gives me some errors:

I can't add Text components
I can add a Video, but it shows the edit modal inside the iFrame

It's a known issue: #2620

[bradenmacdonald]

I read through the code and didn't see any problems.