Fix: Nits on the new sidebars [FC-0123]

[ChrisChV]

Description

• Fix multiple nits/issues in the new sidebars:

#2638 (comment)

The sidebar opens when a container is clicked, but not when it is newly created.

#2634 (comment)

If the unit is a draft and has never been published, the view live button if clicked takes me to a random unit in the course (not in the same section or subsection, not even in the closest published unit). What was the expected behavior in this instance?: I think I would expect to have the view live button on a unit page for an Draft (Never published) unit be disabled. Maybe there's even information for the user on hover that explains that a unit page must have been published to be viewed live.

#2868 (comment)

1 - [nit / very minor] I'm still seeing this issue, here's a screenshot to show the oval sizing of the click target for expand / collapse. The focus ring / circle around the expand / collapse icon is wider than it is tall, and the size of this area is smaller than the equivalent hover / click targets for the overflow menu / drag handles on the right side.

[nit / very minor] The padding /spacing around the controls is a bit off relative to Figma, additional space around the controls as well as a left side border even when collapsed would help as well.

[nit / very minor] The elements in here need a bit more padding to separate them from the Add New / Add Existing tab elements.

10 - [nit] The box shadow feels like it might be 1 elevation level higher than expected but I wasn't entirely sure how to immediately convert the rem sizing into what is in Figma.

Supporting information

• Github issues:
  • Course Outline: Section/Subsections/Unit Info Sidebar #2638 (comment)
  • Unit Page: Header Update #2634 (comment)
  • UX/UI bugs for new course outline and unit page sidebars #2868 (comment)
• Internal ticket: https://tasks.opencraft.com/browse/FAL-4338

Testing instructions

• Go to the course outline of a course.
• Create some containers. Verify that the container is selected and the info sidebar is open.
• In the cointainers cards, verify that the toggle icon is rounded.
• Verify tha paddings in the sidebar buttons.
• Open the Add sidebar and verify the padding of the buttons. Also verify the new shadow of the buttons.
• Create a unit. Go to the unit page. Verify that the Live button is disabled.
• Publish the unit. Verify that the Live button is enabled.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

• Any new files are using TypeScript (.ts, .tsx).
• Avoid propTypes and defaultProps in any new or modified code.
• Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
• Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
• Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
• All new i18n messages in messages.ts files have a description for translators to use.
• Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

[openedx-webhooks]

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.47%. Comparing base (cc1af47) to head (c1a3a9d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2985   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files        1383     1383           
  Lines       32645    32657   +12     
  Branches     7481     7483    +2     
=======================================
+ Hits        31168    31180   +12     
+ Misses       1421     1408   -13     
- Partials       56       69   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bradenmacdonald]

Nice work, thanks! The fixes all look good to me. I tested them and reviewed the code.

[bradenmacdonald]

Not something you need to fix now, but: this button should really be a link (<Button as="a" href="...">), since it changes the URL.