Skip to content

fix: coerce multiple choice text elements to String#2752

Merged
bradenmacdonald merged 1 commit intoopenedx:masterfrom
raccoongang:max/fix-multiple-choice-olx-parser
Dec 18, 2025
Merged

fix: coerce multiple choice text elements to String#2752
bradenmacdonald merged 1 commit intoopenedx:masterfrom
raccoongang:max/fix-multiple-choice-olx-parser

Conversation

@cmltaWt0
Copy link
Copy Markdown
Contributor

Description

"No answer specified" confirmation window is displayed all the time after the second save for dropdown.

234

Steps to Reproduce:

  1. Add new Unit
  2. Add new component Problem
  3. Choose Dropdown
  4. Fill in at least question and answers (for the correct answer, enter the number)
  5. Click Save
  6. Click on Edit for problem again
  7. Click Save

This PR is a possible replacement for #2429

@bradenmacdonald I've create a new PR based on your suggestion here.
If this PR is good for us - I'll close the #2429

@cmltaWt0 cmltaWt0 self-assigned this Dec 14, 2025
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Dec 14, 2025
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @cmltaWt0!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.90%. Comparing base (42acb53) to head (98b2b11).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2752   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files        1235     1235           
  Lines       28260    28261    +1     
  Branches     6433     6433           
=======================================
+ Hits        26819    26820    +1     
  Misses       1370     1370           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Dec 15, 2025
@bradenmacdonald bradenmacdonald merged commit 4df44ab into openedx:master Dec 18, 2025
9 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Dec 18, 2025
@bradenmacdonald
Copy link
Copy Markdown
Contributor

Thanks!

@cmltaWt0 cmltaWt0 deleted the max/fix-multiple-choice-olx-parser branch January 21, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants