feat: New header in course unit page [FC-0114]#2751
feat: New header in course unit page [FC-0114]#2751ChrisChV merged 10 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2751 +/- ##
==========================================
+ Coverage 95.12% 95.13% +0.01%
==========================================
Files 1267 1267
Lines 29604 29685 +81
Branches 6495 6516 +21
==========================================
+ Hits 28160 28241 +81
Misses 1386 1386
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
navinkarkera
left a comment
There was a problem hiding this comment.
@ChrisChV Looks good, we just need to move the status bar outside of title component to match the designs better.
bradenmacdonald
left a comment
There was a problem hiding this comment.
Thanks, the code looks good to me. I'd just like to see a few more comments explaining things, especially explaining why we're checking certain things.
| </ButtonGroup> | ||
| </Stack> | ||
| )} | ||
| {[COURSE_BLOCK_NAMES.libraryContent.id, COURSE_BLOCK_NAMES.splitTest.id].includes(category) && ( |
There was a problem hiding this comment.
Is it only for these two types of blocks? Maybe you can add a comment explaining why we show this edit button for these two types of blocks only.
There was a problem hiding this comment.
Both this component and HeaderTitle already existed; I've made changes and converted them to TSX. Regarding the libraryContent block type, there's a page that displays the content of a Legacy Library Content block. Regarding the splitTest type, I haven't found how to access that page; it might be for use in tests. This component could be refactored to improve it (by separating it), but I don't have much budget left for that.
I added the comments: 985a7f8
Description
ENABLE_UNIT_PAGE_NEW_DESIGNflag createdSupporting information
Testing instructions
Hide from learnersandEnable discussioncheck. Verify that the labels for both appear in the status bar.Restrict access tosection. Verify that the group names appear in the status bar.Other information
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'