Skip to content

feat: New header in course unit page [FC-0114]#2751

Merged
ChrisChV merged 10 commits intoopenedx:masterfrom
open-craft:chris/FAL-4301-new-unit-header
Jan 26, 2026
Merged

feat: New header in course unit page [FC-0114]#2751
ChrisChV merged 10 commits intoopenedx:masterfrom
open-craft:chris/FAL-4301-new-unit-header

Conversation

@ChrisChV
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV commented Dec 12, 2025

Description

  • ENABLE_UNIT_PAGE_NEW_DESIGN flag created
  • New Status Bard implemented in the header of the course unit page.
  • New buttons added in the header of the course unit page.
  • Which user roles will this change impact? "Course Author".
image image image image

Supporting information

Testing instructions

  • Create a new course
  • Create a new unit.
  • Verify the never published state.
  • Open the unit settings and check the Hide from learners and Enable discussion check. Verify that the labels for both appear in the status bar.
  • Open the unit settings and add some groups in the Restrict access to section. Verify that the group names appear in the status bar.
  • Publish the unit. Verify that the status is Scheduled.
  • Make changes in the unit. Verify that the Unpublished changes state appears.
  • Return to the course and set a start date after today.
  • Return to the published unit and verify that the visibility state is Live.

Other information

  • In the Unpublished changes section, it is not currently possible to obtain the number of unpublished changes.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 12, 2025
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Dec 12, 2025

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Dec 12, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Dec 12, 2025
@ChrisChV ChrisChV marked this pull request as draft December 15, 2025 19:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.13%. Comparing base (1626d68) to head (a8d0a7e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2751      +/-   ##
==========================================
+ Coverage   95.12%   95.13%   +0.01%     
==========================================
  Files        1267     1267              
  Lines       29604    29685      +81     
  Branches     6495     6516      +21     
==========================================
+ Hits        28160    28241      +81     
  Misses       1386     1386              
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV changed the title feat: New header un course unit page feat: New header un course unit page [FC-0114] Dec 17, 2025
@ChrisChV ChrisChV added the FC Relates to an Axim Funded Contribution project label Dec 17, 2025
@ChrisChV ChrisChV changed the title feat: New header un course unit page [FC-0114] feat: New header in course unit page [FC-0114] Dec 31, 2025
@ChrisChV ChrisChV marked this pull request as ready for review January 16, 2026 18:04
Copy link
Copy Markdown
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Looks good, we just need to move the status bar outside of title component to match the designs better.

Comment thread src/course-unit/header-title/HeaderTitle.tsx Outdated
Copy link
Copy Markdown
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the code looks good to me. I'd just like to see a few more comments explaining things, especially explaining why we're checking certain things.

</ButtonGroup>
</Stack>
)}
{[COURSE_BLOCK_NAMES.libraryContent.id, COURSE_BLOCK_NAMES.splitTest.id].includes(category) && (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only for these two types of blocks? Maybe you can add a comment explaining why we show this edit button for these two types of blocks only.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both this component and HeaderTitle already existed; I've made changes and converted them to TSX. Regarding the libraryContent block type, there's a page that displays the content of a Legacy Library Content block. Regarding the splitTest type, I haven't found how to access that page; it might be for use in tests. This component could be refactored to improve it (by separating it), but I don't have much budget left for that.
I added the comments: 985a7f8

Comment thread src/course-unit/header-navigations/HeaderNavigations.tsx
Comment thread src/course-unit/header-title/HeaderTitle.tsx
Comment thread src/course-unit/CourseUnit.tsx Outdated
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to In Eng Review in Contributions Jan 23, 2026
@ChrisChV ChrisChV merged commit ef93e95 into openedx:master Jan 26, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Jan 26, 2026
@ChrisChV ChrisChV deleted the chris/FAL-4301-new-unit-header branch January 26, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants