feat: add Page Banner Slot for Schedule and Details Page#2748
feat: add Page Banner Slot for Schedule and Details Page#2748bradenmacdonald merged 9 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
+ Coverage 94.89% 94.95% +0.05%
==========================================
Files 1235 1246 +11
Lines 28254 28642 +388
Branches 6223 6528 +305
==========================================
+ Hits 26813 27198 +385
+ Misses 1383 1373 -10
- Partials 58 71 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bradenmacdonald
left a comment
There was a problem hiding this comment.
Thanks for the nice PR. I have a few concerns about the plugin slot props, and hope we can simplify them. Otherwise this looks great.
|
@bradenmacdonald, sorry for the delay; I was on vacation. This is ready for another look |
|
No problem @Anas12091101 , so was I. This looks great now. Thanks for making those changes. |
…enedx#2748) * feat: add Page Banner Slot for Schedule and Details Page * fix: js to ts * fix: remove js * fix: lint issues * fix: issues * fix: lint issues * fix: issues * fix: issue * fix: issue
Description
This PR adds a Page Banner Slot in the Schedule and Details Page to allow customization of the banner message, which is currently hardcoded.
Useful information to include:
By default:

Overridden by Slot:

Supporting information
https://github.com/mitodl/hq/issues/9362
Testing instructions
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'