chore: upgrade react-datepicker#2709
Conversation
|
Thanks for the pull request, @asajjad2! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| "prop-types": "^15.8.1", | ||
| "react": "^18.3.1", | ||
| "react-datepicker": "^8.0.0", | ||
| "react-datepicker": "8.10.0", |
There was a problem hiding this comment.
Please use "^8.10.0" unless we need to pin it to this exact point release version.
Also, you'll have to run npm install as well to update package-lock.json accordingly. Make sure you have the latest version of npm when doing so. You can then ping me for review anytime.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2709 +/- ##
==========================================
+ Coverage 94.85% 94.89% +0.04%
==========================================
Files 1232 1235 +3
Lines 27899 28254 +355
Branches 6316 6222 -94
==========================================
+ Hits 26464 26813 +349
- Misses 1364 1383 +19
+ Partials 71 58 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -174,7 +174,6 @@ | |||
| "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.24.9.tgz", | |||
| "integrity": "sha512-5e3FI4Q3M3Pbr21+5xJwCv6ZT6KmGkI0vw3Tozy5ODAQFTIWe37iT8Cr7Ice2Ntb+M3iSKCEWMB1MBgKrW3whg==", | |||
| "license": "MIT", | |||
| "peer": true, | |||
There was a problem hiding this comment.
All these hundreds of changes to "peer": true, should not be showing up in the diff. The reason is usually that you are using an old version of npm. Could you please update your NPM install (npm install -g npm@latest) and then run npm install? Sorry for the hassle.
bradenmacdonald
left a comment
There was a problem hiding this comment.
I tested this and it's working well; just need the package-lock file updated with the latest NPM and we can merge.
What are the relevant tickets?
#9097
Description (What does it do?)
Upgrades react-datepicker to
8.10.0so we inherit the upstream enhancement that adds keyboard accessibility for time-only pickers.Screencast
Screen.Recording.2025-11-11.at.3.38.55.PM.mov
Testing
Spot check time-only pickers: verify arrow keys adjust time, enter commits, dropdown scrolls correctly.