Skip to content

fix: don't revert to advanced editor if block contains copied_from fields #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisChV merged 2 commits into from
Nov 19, 2025
Merged

fix: don't revert to advanced editor if block contains copied_from fields #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a324591
fix: don't revert to advanced editor if block contains copied_from fi…
navinkarkera Nov 18, 2025
54a46a9
fix: consistent card header height
navinkarkera Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/editors/containers/ProblemEditor/data/mockData/olxTestData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// lint is disabled for this file due to strict spacing

export const checkboxesOLXWithFeedbackAndHintsOLX = {
rawOLX: `<problem url_name="this_should_be_ignored">
rawOLX: `<problem url_name="this_should_be_ignored" copied_from_version="2" copied_from_block="some-block">
<choiceresponse>
<p>You can use this template as a guide to the simple editor markdown and OLX markup to use for checkboxes with hints and feedback problems. Edit this component to replace this template with your own assessment.</p>
<label>Add the question text, or prompt, here. This text is required.</label>
Expand Down
2 changes: 2 additions & 0 deletions src/editors/data/constants/problem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,8 @@ export const ignoredOlxAttributes = [
'@_url_name',
'@_x-is-pointer-node',
'@_markdown_edited',
'@_copied_from_block',
'@_copied_from_version',
] as const;

// Useful for the block creation workflow.
Expand Down
2 changes: 1 addition & 1 deletion src/library-authoring/components/BaseCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const BaseCard = ({
<Card.Header
className={`library-item-header ${getComponentStyleColor(itemType)}`}
title={
<Icon src={itemIcon} className="library-item-header-icon" />
<Icon src={itemIcon} className="library-item-header-icon my-2" />
}
actions={(
<div
Expand Down