Skip to content

fix: separate initialValue to not cause re-render on updates #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradenmacdonald merged 1 commit into from
Nov 5, 2025
Merged

fix: separate initialValue to not cause re-render on updates #2599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/schedule-and-details/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ const ScheduleAndDetails = ({ courseId }) => {
license,
language,
subtitle,
overview,
duration,
selfPaced,
startDate,
Expand All @@ -128,7 +127,6 @@ const ScheduleAndDetails = ({ courseId }) => {
instructorInfo,
enrollmentStart,
shortDescription,
aboutSidebarHtml,
preRequisiteCourses,
entranceExamEnabled,
courseImageAssetPath,
Expand All @@ -140,6 +138,12 @@ const ScheduleAndDetails = ({ courseId }) => {
} = editedValues;

useScrollToHashElement({ isLoading });
// No need to get overview and aboutSidebarHtml from editedValues
// As updating them re-renders TinyMCE
// Which causes issues with TinyMCE editor cursor position
// https://www.tiny.cloud/docs/tinymce/5/react/#initialvalue
const { overview: initialOverview } = courseDetails || {};
const { aboutSidebarHtml: initialAboutSidebarHtml } = courseDetails || {};

if (isLoading) {
// eslint-disable-next-line react/jsx-no-useless-fragment
Expand Down Expand Up @@ -277,12 +281,12 @@ const ScheduleAndDetails = ({ courseId }) => {
)}
<IntroducingSection
title={title}
overview={overview}
overview={initialOverview}
duration={duration}
subtitle={subtitle}
introVideo={introVideo}
description={description}
aboutSidebarHtml={aboutSidebarHtml}
aboutSidebarHtml={initialAboutSidebarHtml}
shortDescription={shortDescription}
aboutPageEditable={aboutPageEditable}
sidebarHtmlEnabled={sidebarHtmlEnabled}
Expand Down